https://github.com/steakhal approved this pull request.
Right. Very detailed summary - I should have read it before reading the patch :D - bad habits. > This can be simulated in the regression test by setting a very low STU budget > and enabling CTU mode. Actually, we don't need to do any CTU work or even > provide extra TUs; this is because the switch to the CTU worklist (empty) is > always done when CTU mode is enabled. Right, but I think I'd sleep better if we could demonstrate some of the baseline behavior. Tests that expect no warnings feel weird because they had the opportunity to differentiate the expected behavior from a baseline. See my comments inline. I'm also fine with what is presented here so I'll let you two think about this and judge. Thanks for coming by! https://github.com/llvm/llvm-project/pull/219225 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
