steakhal wrote:

> > What is a commit signature? If you mean commit hash, then yes. It gets a 
> > new committer date, whixh impacts the hash. And of course since it gets a 
> > different xommit history (because it squashes all the commits of the PR 
> > into one). So yes, the hash will change.
> 
> I actually meant a (cryptographic) commit signature (the "verified" next to 
> the commit; PGP, or SSH, or X.509, or whatever signature scheme one is 
> using); I sign all my commits, whether the signatures will end up preserved 
> at merge time or not. It's fine, of course, for the project to discard/squash 
> away those signatures; I just didn't know what the practice was.

It will have a different signature but Github trusts its own signature.

https://github.com/llvm/llvm-project/pull/219568
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to