https://github.com/AaronBallman requested changes to this pull request.
I don't expect this to cause merge conflicts or anything in downstreams but I do wonder what the need is for the churn. Personally, I find the inline diagnostic checks to be easier to read than the `@+1` ones and make it harder to accidentally break the test. But this is pretty subjective, others may have different opinions. I definitely find the `RUN` lines to be harder to understand now because they're broken up across multiple lines. https://github.com/llvm/llvm-project/pull/220269 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
