arphaman added a comment.

Generally it LG



================
Comment at: lib/CodeGen/CodeGenPGO.cpp:244
+  DEFINE_NESTABLE_TRAVERSAL(CXXTryStmt)
+  DEFINE_NESTABLE_TRAVERSAL(CXXCatchStmt)
+
----------------
What about `ObjCAtTryStmt`?


================
Comment at: lib/CodeGen/CodeGenPGO.cpp:321
+        return PGOHash::ReturnStmt;
+      case Stmt::CXXThrowExprClass:
+        return PGOHash::ThrowExpr;
----------------
Might as well include the `ObjCAtThrowStmt` as well.


https://reviews.llvm.org/D39446



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to