llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Hardik Kumar (hardikxk) <details> <summary>Changes</summary> Fix some obvious typos and grammar mistakes in the CIR docs. --- Full diff: https://github.com/llvm/llvm-project/pull/220877.diff 2 Files Affected: - (modified) clang/docs/CIR/CleanupAndEHDesign.md (+3-3) - (modified) clang/docs/CIR/CodeDuplication.md (+2-2) ``````````diff diff --git a/clang/docs/CIR/CleanupAndEHDesign.md b/clang/docs/CIR/CleanupAndEHDesign.md index 092568f04b869..b8967e745889a 100644 --- a/clang/docs/CIR/CleanupAndEHDesign.md +++ b/clang/docs/CIR/CleanupAndEHDesign.md @@ -892,7 +892,7 @@ LLVM IR codegen. Only the EH cleanup requires `cir.begin_cleanup` and `cir.end_cleanup` operations. If the `SomeClass` constructor throws an exception, it unwinds to an EH -catch block (`^bb3`), which has excecutes a `cir.eh.initiate` operation +catch block (`^bb3`), which executes a `cir.eh.initiate` operation before branching to a shared catch dispatch block (`^bb6`). If the `doSomething()` function throws an exception, it unwinds to an EH @@ -1422,7 +1422,7 @@ parent token, which may either be none or the token returned by a previous `cir.catchpad` operation. This is followed by a list of blocks which contain catch handlers. Each block in this list must begin with a `cir.catchpad` operation. Finally, the unwind destination is provided to -specify where excution continues if the exception is not caught by any +specify where execution continues if the exception is not caught by any of the handlers, with unwind to caller indicating that the unwind is not handled further in the current function. This operation returns a token that is used as the operand for `cir.catchpad` operations associated @@ -1469,7 +1469,7 @@ cir.catchret from %8 to ^bb8 The `cir.catchret` operation takes an operand which specifies the `cir.catchpad` operation which is completed by this operation and a -block at which excution should be resumed. +block at which execution should be resumed. #### Example: Try-catch with cleanup diff --git a/clang/docs/CIR/CodeDuplication.md b/clang/docs/CIR/CodeDuplication.md index aa22a790cd6da..1cae7a30500bb 100644 --- a/clang/docs/CIR/CodeDuplication.md +++ b/clang/docs/CIR/CodeDuplication.md @@ -58,8 +58,8 @@ implementing refactorings that make sense independent of the code sharing problem. We have discussed various ways that major classes such as CGCXXABI/CIRGenCXXABI -could be refactored to allow parts of there implementation to be shared today -through inheritence and templated base classes. However, this may prove to be +could be refactored to allow parts of their implementation to be shared today +through inheritance and templated base classes. However, this may prove to be wasted effort when the permanent solution is developed. Also, deferring this kind of intertwined implementation prevents introducing cross-dependencies that would make it more difficult to remove one IR code generation implementation `````````` </details> https://github.com/llvm/llvm-project/pull/220877 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
