https://github.com/AaronBallman approved this pull request.
LGTM aside from a few minor nits. > I think I would have liked to see a diagnostic saying "hey you are using imag > with a non complex type" I am surprised that you can use it with a non-complex type, but given that it's accepted by GCC and Clang for so long, I think that's a separate PR (and maybe worth filing a feature request over; hopefully such a diagnostic wouldn't break a lot of code, but investigation is needed). https://github.com/llvm/llvm-project/pull/218270 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
