dschuff wrote: > This is great! I'm excited to finally migrate EMSCRIPTEN_KEEPALIVE to > something better. > > Have you tried running the emscripten test suite against this change with > `EMSCRIPTEN_KEEPALIVE` updated to use this instead? > > Regarding the zero-arg vs new attribute things, I don't feel too strongly. > Perhaps @sunfishcode or @alexcrichton have an opinion? > > Presumably as the followup we can then remove the emscripten-specific > handling of the `used`?
Yes, and yes. The EMSCRIPTEN_KEEPALIVE change is just a one-line change to the macro. In theory if we are going to change the IR behavior we should warn any maintainers of frontends who target Wasm. Unfortunately I don't actually know of a good way to do that, aside from the Rust maintainers. https://github.com/llvm/llvm-project/pull/221363 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
