On Sun, Nov 12, 2017 at 12:53 PM Anton via Phabricator < revi...@reviews.llvm.org> wrote:
> xgsa added a comment. > > In https://reviews.llvm.org/D39622#919579, @aprantl wrote: > > > For clarification: what is the "symbols table" you are referring to in > the description? > > > I meant the data dumped with "nm -an ./test". > > By the way, I haven't abandoned the patch, I have found one more case when > my fix doesn't work and I am working on improvement. Nevertheless, it would > be helpful to get answers to the questions in this review (about changing > the "Indentation" field and about the test). > I'm confused then - nm's output uses a demangler, the file doesn't actually have either "Impl<TagType::Tag1>" or "Impl<(TagType)0>" in it. It's probably not OK/possible to ensure the type always matches lldb's demangled form. Other produces might have another idea of what its demangled form looks like. > > > Repository: > rL LLVM > > https://reviews.llvm.org/D39622 > > > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits