https://github.com/NagyDonat commented:

The change looks good and I think this is a good approach to handle this 
problem with the weak symbols in CTU analysis. However, I found simplification 
opportunities (see inline comments) and I'm not familiar enough with 
`clang-extdef-mapping` to give a formal approval. Please try to find a reviewer 
who is familiar with this part of the codebase.

https://github.com/llvm/llvm-project/pull/222010
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to