https://github.com/im-lunex updated https://github.com/llvm/llvm-project/pull/222841
From 98a6983e0cb9301fbd5c88ea6365828b0d91c6e2 Mon Sep 17 00:00:00 2001 From: im-lunex <[email protected]> Date: Fri, 11 Sep 2026 00:58:58 +0600 Subject: [PATCH] [Sema] Check arg count for builtins with CustomTypeChecking --- clang/lib/Sema/SemaChecking.cpp | 15 +++++++++++++ .../PowerPC/builtins-too-many-args-check.cpp | 22 +++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 clang/test/Sema/PowerPC/builtins-too-many-args-check.cpp diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp index 0e85af73696dc..cc68bf5ef5413 100644 --- a/clang/lib/Sema/SemaChecking.cpp +++ b/clang/lib/Sema/SemaChecking.cpp @@ -4193,6 +4193,21 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID, if (getLangOpts().HLSL && HLSL().CheckBuiltinFunctionCall(BuiltinID, TheCall)) return ExprError(); + // check if the builtin has CustomTypeChecking or not, if it dose we get the + // already parsed type string of the builtin and compare that with the + // caller's passed args and give error for too much args + if (Context.BuiltinInfo.hasCustomTypechecking(BuiltinID)) { + ASTContext::GetBuiltinTypeError Error; + QualType BuiltinFTy = Context.GetBuiltinType(BuiltinID, Error); + if (!BuiltinFTy.isNull() && !Error) { + if (const FunctionProtoType *FPT = + dyn_cast<FunctionProtoType>(BuiltinFTy.getTypePtr())) + if (!FPT->isVariadic() && + checkArgCountAtMost(TheCall, FPT->getNumParams())) + return ExprError(); + } + } + // Since the target specific builtins for each arch overlap, only check those // of the arch we are compiling for. if (Context.BuiltinInfo.isTSBuiltin(BuiltinID)) { diff --git a/clang/test/Sema/PowerPC/builtins-too-many-args-check.cpp b/clang/test/Sema/PowerPC/builtins-too-many-args-check.cpp new file mode 100644 index 0000000000000..15d30fd1dffe5 --- /dev/null +++ b/clang/test/Sema/PowerPC/builtins-too-many-args-check.cpp @@ -0,0 +1,22 @@ +// Testfile for (https://github.com/llvm/llvm-project/issues/216669) + +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -target-feature +power9-vector -triple powerpc64-unknown-unknown -fsyntax-only -verify %s +// RUN: %clang_cc1 -target-feature +power9-vector -triple powerpc64le-unknown-unknown -fsyntax-only -verify %s +// RUN: %clang_cc1 -target-feature +power9-vector -triple powerpc-unknown-unknown -fsyntax-only -verify %s + +vector unsigned char test_bcdsetsign_too_many(vector unsigned char a) { + return __builtin_ppc_bcdsetsign(a, 1, 2); // expected-error {{too many arguments to function call, expected at most 2, have 3}} +} + +vector unsigned char test_national2packed_too_many(vector unsigned char a) { + return __builtin_ppc_national2packed(a, 1, 0); // expected-error {{too many arguments to function call, expected at most 2, have 3}} +} + +vector unsigned char test_packed2zoned_too_many(vector unsigned char a) { + return __builtin_ppc_packed2zoned(a, 1, 0); // expected-error {{too many arguments to function call, expected at most 2, have 3}} +} + +vector unsigned char test_zoned2packed_too_many(vector unsigned char a) { + return __builtin_ppc_zoned2packed(a, 1, 0); // expected-error {{too many arguments to function call, expected at most 2, have 3}} +} _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
