================
@@ -260,6 +261,33 @@ TEST(SerializationTest, BinaryConversions) {
               UnorderedElementsAreArray(yamlFromRelations(*In->Relations)));
 }
 
+// Every SymbolKind must have a YAML spelling, otherwise writing the index
+// produces invalid YAML (or aborts with assertions enabled).
+TEST(SerializationTest, YAMLSymbolKindRoundTrip) {
+  SymbolSlab::Builder Builder;
+  for (unsigned K = 0; K <= static_cast<unsigned>(index::SymbolKind::Concept);
----------------
ArcsinX wrote:

Oh, sorry. I didn't expect that adding `Count` leads to clang/libclang changes. 
Fixing a self-contained bug in clangd should not lead to clang/libclang changes 
only to ensure that newly added test covers all symbol kinds.
So, can you please revert Count addition? loop in your test can be just from 
Unknow till Concept.
Sorry, once again.

https://github.com/llvm/llvm-project/pull/222070
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to