IIRC, and I can hardly guarantee I do, the issue is that libclang installing signal handlers doesn’t play well with the arbitrary applications which can be linking libclang.
- Daniel On Thu, Nov 16, 2017 at 3:26 PM Rafael Avila de Espindola < rafael.espind...@gmail.com> wrote: > Daniel Dunbar <dan...@zuster.org> writes: > > > Author: ddunbar > > Date: Mon Jan 31 16:00:44 2011 > > New Revision: 124613 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=124613&view=rev > > Log: > > libclang: Don't allow RemoveFileOnSignal to be called via libclang, > badness can > > ensue. > > > Sorry for digging out such an old commit, but do you remember what > badness that ensues if RemoveFileOnSignal is called? > > Would the same badness ensue if FILE_FLAG_DELETE_ON_CLOSE were used on > Windows? > > > Thanks, > Rafael > > > > Modified: > > cfe/trunk/lib/Frontend/FrontendActions.cpp > > > > Modified: cfe/trunk/lib/Frontend/FrontendActions.cpp > > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/FrontendActions.cpp?rev=124613&r1=124612&r2=124613&view=diff > > > ============================================================================== > > --- cfe/trunk/lib/Frontend/FrontendActions.cpp (original) > > +++ cfe/trunk/lib/Frontend/FrontendActions.cpp Mon Jan 31 16:00:44 2011 > > @@ -104,7 +104,10 @@ > > return true; > > } > > > > - OS = CI.createDefaultOutputFile(true, InFile); > > + // We use createOutputFile here because this is exposed via libclang, > and we > > + // must disable the RemoveFileOnSignal behavior. > > + OS = CI.createOutputFile(CI.getFrontendOpts().OutputFile, > /*Binary=*/true, > > + /*RemoveFileOnSignal=*/false, InFile); > > if (!OS) > > return true; > > > > > > > > _______________________________________________ > > cfe-commits mailing list > > cfe-comm...@cs.uiuc.edu > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
