pedropiin wrote: Hi @skatrak . Thank you for the review! I just finished addresing the nits (and replied to your test suggestion).
As this is my first time contributing to LLVM, to my understanding, I need someone to approve the pre-merge CI and the merge itself. If everything looks ok for you, could help me by approving the worfklow and merging if everything passes? If I understood this wrong and this is not how it works, please let me know. https://github.com/llvm/llvm-project/pull/204999 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
