github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,c --
clang/lib/CodeGen/CGExprConstant.cpp clang/lib/CodeGen/CGObjCGNU.cpp
clang/lib/CodeGen/CGObjCMac.cpp clang/lib/CodeGen/CGVTT.cpp
clang/lib/CodeGen/ConstantInitBuilder.cpp clang/lib/CodeGen/ItaniumCXXABI.cpp
clang/lib/CodeGen/MicrosoftCXXABI.cpp
clang/test/CodeGen/ptrauth-qualifier-const-init.c
clang/test/CodeGen/ptrauth-restricted-intptr-qualifier.c
clang/test/CodeGenCXX/OmitRTTIComponentABI/simple-vtable-definition.cpp
clang/test/CodeGenCXX/PR26569.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/child-inheritted-from-parent-in-comdat.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/child-vtable-in-comdat.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/cross-translation-unit-1.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/cross-translation-unit-2.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/deleted-virtual-method.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/diamond-inheritance.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/diamond-virtual-inheritance.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/inheritted-virtual-function.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/inline-virtual-function.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/inlined-key-function.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/multiple-inheritance.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/override-pure-virtual-method.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/overriden-virtual-function.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/parent-and-child-in-comdats.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/parent-vtable-in-comdat.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/relative-vtables-flag.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/relative-vtables-hwasan.cpp
clang/test/CodeGenCXX/RelativeVTablesABI/simple-vtable-definition.cpp
clang/test/CodeGenCXX/const-init-cxx11.cpp
clang/test/CodeGenCXX/constructor-init.cpp
clang/test/CodeGenCXX/copy-constructor-synthesis-2.cpp
clang/test/CodeGenCXX/copy-constructor-synthesis.cpp
clang/test/CodeGenCXX/dllexport.cpp clang/test/CodeGenCXX/dllimport-rtti.cpp
clang/test/CodeGenCXX/dynamic-cast-address-space.cpp
clang/test/CodeGenCXX/dynamic-cast-exact.cpp
clang/test/CodeGenCXX/microsoft-abi-vftables.cpp
clang/test/CodeGenCXX/microsoft-interface.cpp
clang/test/CodeGenCXX/ms-local-vft-alias-comdat.cpp
clang/test/CodeGenCXX/ptrauth-apple-kext-indirect-call-2.cpp
clang/test/CodeGenCXX/ptrauth-apple-kext-indirect-call.cpp
clang/test/CodeGenCXX/ptrauth-apple-kext-indirect-virtual-dtor-call.cpp
clang/test/CodeGenCXX/ptrauth-explicit-vtable-pointer-control.cpp
clang/test/CodeGenCXX/ptrauth-global-constant-initializers.cpp
clang/test/CodeGenCXX/ptrauth-member-function-pointer.cpp
clang/test/CodeGenCXX/ptrauth-rtti-layout.cpp
clang/test/CodeGenCXX/ptrauth-type-info-vtable.cpp
clang/test/CodeGenCXX/ptrauth-virtual-function.cpp
clang/test/CodeGenCXX/ptrauth-vtable-in-vtt.cpp
clang/test/CodeGenCXX/ptrauth-vtable-virtual-inheritance-thunk.cpp
clang/test/CodeGenCXX/rtti-mingw64.cpp clang/test/CodeGenCXX/rtti-qualfn.cpp
clang/test/CodeGenCXX/skip-vtable-pointer-initialization.cpp
clang/test/CodeGenCXX/static-init.cpp
clang/test/CodeGenCXX/strict-vtable-pointers.cpp
clang/test/CodeGenCXX/typeinfo-with-address-space.cpp
clang/test/CodeGenCXX/visibility.cpp
clang/test/CodeGenCXX/vtable-align-address-space.cpp
clang/test/CodeGenCXX/vtable-align.cpp
clang/test/CodeGenCXX/vtable-assume-load-address-space.cpp
clang/test/CodeGenCXX/vtable-assume-load.cpp
clang/test/CodeGenCXX/vtable-pointer-initialization-address-space.cpp
clang/test/CodeGenCXX/vtable-pointer-initialization.cpp
clang/test/CodeGenCXX/vtt-layout-address-space.cpp
clang/test/CodeGenCXX/vtt-layout.cpp
clang/test/OpenMP/target_data_use_device_ptr_inheritance_codegen.cpp
--diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/CodeGen/CGVTT.cpp b/clang/lib/CodeGen/CGVTT.cpp
index d4bbfcf15..b3207fdd6 100644
--- a/clang/lib/CodeGen/CGVTT.cpp
+++ b/clang/lib/CodeGen/CGVTT.cpp
@@ -70,40 +70,40 @@ CodeGenVTables::EmitVTTDefinition(llvm::GlobalVariable *VTT,
"Did not find ctor vtable address point!");
}
- llvm::Constant *Idxs[] = {
- llvm::ConstantInt::get(CGM.Int32Ty, 0),
- llvm::ConstantInt::get(CGM.Int32Ty, AddressPoint.VTableIndex),
- llvm::ConstantInt::get(CGM.Int32Ty, AddressPoint.AddressPointIndex),
- };
-
- // Add inrange attribute to indicate that only the VTableIndex can be
- // accessed.
- unsigned ComponentSize =
- CGM.getDataLayout().getTypeAllocSize(getVTableComponentType());
- unsigned VTableSize = CGM.getDataLayout().getTypeAllocSize(
- cast<llvm::StructType>(VTable->getValueType())
- ->getElementType(AddressPoint.VTableIndex));
- unsigned Offset = ComponentSize * AddressPoint.AddressPointIndex;
- llvm::ConstantRange InRange(
- llvm::APInt(32, (int)-Offset, true),
- llvm::APInt(32, (int)(VTableSize - Offset), true));
- llvm::Constant *Init = llvm::ConstantExpr::getGetElementPtr(
- CGM.getDataLayout(), VTable->getValueType(), VTable, Idxs,
- llvm::GEPNoWrapFlags::inBounds(), InRange);
-
- if (auto PAuthQual =
- CGM.getVTablePointerAuthentication(VTTVT.getBase(),
- /*IsVTTEntry=*/true)) {
- llvm::Constant *Address = nullptr;
- if (PAuthQual->isAddressDiscriminated())
- Address = llvm::ConstantExpr::getGetElementPtr(
- CGM.getDataLayout(), VTT->getType(), VTT,
- llvm::ConstantInt::get(CGM.Int32Ty, Idx));
- auto *Discriminator = llvm::ConstantInt::get(
- CGM.IntPtrTy, PAuthQual->getExtraDiscriminator());
- Init = CGM.getConstantSignedPointer(Init, PAuthQual->getKey(), Address,
- Discriminator);
- }
+ llvm::Constant *Idxs[] = {
+ llvm::ConstantInt::get(CGM.Int32Ty, 0),
+ llvm::ConstantInt::get(CGM.Int32Ty, AddressPoint.VTableIndex),
+ llvm::ConstantInt::get(CGM.Int32Ty, AddressPoint.AddressPointIndex),
+ };
+
+ // Add inrange attribute to indicate that only the VTableIndex can be
+ // accessed.
+ unsigned ComponentSize =
+ CGM.getDataLayout().getTypeAllocSize(getVTableComponentType());
+ unsigned VTableSize = CGM.getDataLayout().getTypeAllocSize(
+ cast<llvm::StructType>(VTable->getValueType())
+ ->getElementType(AddressPoint.VTableIndex));
+ unsigned Offset = ComponentSize * AddressPoint.AddressPointIndex;
+ llvm::ConstantRange InRange(
+ llvm::APInt(32, (int)-Offset, true),
+ llvm::APInt(32, (int)(VTableSize - Offset), true));
+ llvm::Constant *Init = llvm::ConstantExpr::getGetElementPtr(
+ CGM.getDataLayout(), VTable->getValueType(), VTable, Idxs,
+ llvm::GEPNoWrapFlags::inBounds(), InRange);
+
+ if (auto PAuthQual =
+ CGM.getVTablePointerAuthentication(VTTVT.getBase(),
+ /*IsVTTEntry=*/true)) {
+ llvm::Constant *Address = nullptr;
+ if (PAuthQual->isAddressDiscriminated())
+ Address = llvm::ConstantExpr::getGetElementPtr(
+ CGM.getDataLayout(), VTT->getType(), VTT,
+ llvm::ConstantInt::get(CGM.Int32Ty, Idx));
+ auto *Discriminator = llvm::ConstantInt::get(
+ CGM.IntPtrTy, PAuthQual->getExtraDiscriminator());
+ Init = CGM.getConstantSignedPointer(Init, PAuthQual->getKey(), Address,
+ Discriminator);
+ }
VTTComponents.push_back(Init);
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/225415
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
