================
@@ -1834,9 +1834,12 @@ class CodeCompleteFlow {
}
if (Opts.EnableInsertReplace) {
- ReplaceRange.emplace();
- ReplaceRange->start = InsertRange.start;
- ReplaceRange->end = getEndOfCodeCompletionReplace(SM);
----------------
ArcsinX wrote:
nit: maybe just `ReplaceRange->end = (CCContextKind == CCC_IncludedFile) ?
InsertRange.end : getEndOfCodeCompletionReplace(SM);`?
Setting `ReplaceRange` to `InsertRange` and immediately overriding
`ReplaceRange->end` looks a bit strange.
https://github.com/llvm/llvm-project/pull/225473
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
