tbaederr wrote:

I'm not sure about the utility in the end here, I guess the "does this APValue 
contain any non-null pointers" check from the recent PR could be implemented 
using visit() as well. But I suspect we need to know more information about an 
APValue and/or control the iteration order in most cases.

The documentation should probably note that we don't guarantee the iteration 
order. Otherwise LGTM, with the caveat that the API should stay this way and 
_not_ gain a bunch of parameters to control its behavior in the future.

https://github.com/llvm/llvm-project/pull/230243
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to