Lukas =?utf-8?q?Döllerer?= <[email protected]>,
Lukas =?utf-8?q?Döllerer?= <[email protected]>,
Lukas =?utf-8?q?Döllerer?= <[email protected]>,
Lukas =?utf-8?q?Döllerer?= <[email protected]>,
Lukas =?utf-8?q?Döllerer?= <[email protected]>,
Lukas =?utf-8?q?Döllerer?= <[email protected]>,
Lukas =?utf-8?q?Döllerer?= <[email protected]>,
Lukas =?utf-8?q?Döllerer?= <[email protected]>,
Lukas =?utf-8?q?Döllerer?= <[email protected]>,
Lukas =?utf-8?q?Döllerer?= <[email protected]>,
Lukas =?utf-8?q?Döllerer?= <[email protected]>,
Lukas =?utf-8?q?Döllerer?= <[email protected]>,
Lukas =?utf-8?q?Döllerer?= <[email protected]>,
Lukas =?utf-8?q?Döllerer?= <[email protected]>,Derek Schuff
 <[email protected]>,Derek Schuff <[email protected]>,Derek Schuff
 <[email protected]>,Derek Schuff <[email protected]>,Derek Schuff
 <[email protected]>,Derek Schuff <[email protected]>,Derek Schuff
 <[email protected]>,Derek Schuff <[email protected]>,Derek Schuff
 <[email protected]>,Derek Schuff <[email protected]>,Derek Schuff
 <[email protected]>,Derek Schuff <[email protected]>,Derek Schuff
 <[email protected]>,Derek Schuff <[email protected]>,Derek Schuff
 <[email protected]>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/[email protected]>


================
@@ -95,6 +95,8 @@ class Writer {
   void addSections();
 
   void createCustomSections();
+  // Code metadata custom sections must be placed before code section
----------------
aheejin wrote:

Is this comment relevant here? It's not that the order of method declarations 
matters for the section order. It would be better to be placed in the actual 
writing method

https://github.com/llvm/llvm-project/pull/146230
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to