Prabhuk wrote:

Thanks @efriedma-quic, that's fair — there is no good reason for UEFI to 
diverge from MSVC here. I've reworked the patch so UEFI simply follows the 
Windows behavior from #142970:

* clang now creates the `NoDebug` compile unit (and emits the "Debug Info 
Version" module flag) for UEFI targets as it does for Windows.
* `AsmPrinter` registers the CodeView handler for `isOSWindows() || isUEFI()` 
whenever `llvm.dbg.cu` exists, so UEFI objects always carry 
`S_OBJNAME`/`S_COMPILE3`.
* The `CodeViewDebug::beginModule` special case is gone, `uefi-nodebug.ll` now 
expects the compiler info, and the clang COFF tests gained 
`x86_64-unknown-uefi` run lines.

@arsenm the previously deleted no-crash test (`uefi-no-codeview-crash.ll`) is 
kept as-is.


https://github.com/llvm/llvm-project/pull/188383
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to