mstorsjo added inline comments.

================
Comment at: cfe/trunk/lib/Driver/ToolChain.cpp:457
+  if (Triple.isOSWindows())
+    return llvm::ExceptionHandling::WinEH;
+  return llvm::ExceptionHandling::None;
----------------
It looks like this broke some buildbot after all - see e.g. 
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/20371.

Perhaps it's best to just have the default here be None even for Windows, and 
just let it be overridden for MinGW? I don't think we did define `__SEH__` at 
all when targeting MSVC before either, so it should be fine to just leave it 
unset and not override anything from the backend defaults here.


Repository:
  rL LLVM

https://reviews.llvm.org/D39673



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to