MythreyaK wrote: Ran an AI review pass and found 2 bugs. * Empty fallback dir resolved to cwd. Pushed a small change + test for it. * `findMultilibs` always sets sysroot to `FallbackDir` ([here](https://github.com/MythreyaK/llvm-project/blob/b16fe314f35492a27e2f14c4a6fd2abf7f6f595c/clang/lib/Driver/ToolChains/BareMetal.cpp#L276-L278)). So a per-triple yaml and no `--sysroot` adds bad search path `$SYSROOT/usr/lib/clang-runtimes/rv64gc/{inlcude,lib}`. I was planning to address this in a new PR (alongside the discussion in [this review thread](https://github.com/llvm/llvm-project/pull/227965#discussion_r4332778946)).
> Weak LGTM, but landable given Petr's approval too. If I can make other improvements (in this PR or as a follow-up), please let me know! Or if you'd prefer this merged, someone with merge rights needs to hit the button (I don't have merge permissions). https://github.com/llvm/llvm-project/pull/227965 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
