================
@@ -91,30 +91,21 @@ def csv2def(csv_path, def_path):
         for row in csv_reader:
             if row[DEVICE_COLUMN].endswith("generic"):
                 continue
-            if row[MULTIPLIER_COLUMN] == MULTIPLIER_SW:
-                mcus_multiplier_sw.append(row[DEVICE_COLUMN])
-            elif row[MULTIPLIER_COLUMN] in MULTIPLIER_HW_16:
-                mcus_multiplier_hw_16.append(row[DEVICE_COLUMN])
-            elif row[MULTIPLIER_COLUMN] in MULTIPLIER_HW_32:
-                mcus_multiplier_hw_32.append(row[DEVICE_COLUMN])
-            else:
-                assert 0, "Unknown multiplier type"
+            assert row[CPU_COLUMN] in CPUS, "Unknown CPU type"
+            assert row[MULTIPLIER_COLUMN] in MULTIPLIERS, "Unknown multiplier 
type"
+            mcus.append(
+                (
+                    row[DEVICE_COLUMN],
+                    CPUS[row[CPU_COLUMN]],
+                    MULTIPLIERS[row[MULTIPLIER_COLUMN]],
+                )
+            )
 
     with open(def_path, "w") as def_file:
         def_file.write(PREFIX.format(version))
 
-        for mcu in mcus_multiplier_sw:
-            def_file.write(f'MSP430_MCU("{mcu}")\n')
-
-        def_file.write("\n// With 16-bit hardware multiplier\n")
----------------
asl wrote:

Would be great to keep some comments in .def file explaining the fields, order 
and possible values.

https://github.com/llvm/llvm-project/pull/228006
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to