ilya-biryukov added inline comments.
================
Comment at: lib/Sema/SemaCodeComplete.cpp:4609
+ if (SS.isInvalid()) {
+ CodeCompletionContext CC(CodeCompletionContext::CCC_Name);
----------------
ioeric wrote:
> ilya-biryukov wrote:
> > ilya-biryukov wrote:
> > > Why do we alter this code path?
> > Maybe we should add a test or provide examples why the current code does
> > not work for us?
> There is no existing unit test for CodeCompletion, and there is no much to
> test here either. I added a comment with example for this.
Makes sense, thanks for the explanation.
https://reviews.llvm.org/D40563
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
