aaron.ballman added subscribers: dcoughlin, sbaranga, jmolloy.
aaron.ballman added a comment.
Added @dcoughlin for opinions about the static analyzer, added @sbaranga and
@jmolloy for questions about NEON.
================
Comment at: include/clang/Basic/Attr.td:602
def AnalyzerNoReturn : InheritableAttr {
- let Spellings = [GNU<"analyzer_noreturn">];
+ let Spellings = [Clang<"analyzer_noreturn">];
let Documentation = [Undocumented];
----------------
rsmith wrote:
> Hmm, should the clang static analyzer reuse the `clang::` namespace, or
> should it get its own?
Good question, I don't have strong opinions on the answer here, but perhaps
@dcoughlin does?
If we want to use a separate namespace for the analyzer, would we want to use
that same namespace for any clang-tidy specific attributes? Or should
clang-tidy get its own namespace? (Do we ever plan to execute clang-tidy
through the clang driver? That might change our answer.)
================
Comment at: include/clang/Basic/Attr.td:649
def Availability : InheritableAttr {
- let Spellings = [GNU<"availability">];
+ let Spellings = [Clang<"availability">];
let Args = [IdentifierArgument<"platform">, VersionArgument<"introduced">,
----------------
rsmith wrote:
> Does the custom parsing for this work for the C++11 attribute syntax?
Nope; I'll do this one separately (and make sure no other attributes similarly
use custom parsing).
================
Comment at: include/clang/Basic/Attr.td:1218-1228
def NeonPolyVectorType : TypeAttr {
- let Spellings = [GNU<"neon_polyvector_type">];
+ let Spellings = [Clang<"neon_polyvector_type">];
let Args = [IntArgument<"NumElements">];
let Documentation = [Undocumented];
}
def NeonVectorType : TypeAttr {
----------------
rsmith wrote:
> I *think* these are a Clang invention rather than part of the ARM NEON
> intrinsics specification, but perhaps you could ask someone from ARM to
> confirm that.
@sbaranga or @jmolloy -- do you happen to know the answer to this, or know
someone who does?
https://reviews.llvm.org/D40625
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
