https://github.com/NagyDonat approved this pull request.
Looks good to me. "Following the script" I'd say that we should add a regression test which checks the handling of an nonstandard 1-argument `mtx_timedlock`, but I think it would be pointless in practice and we don't have analogous tests for other `CallDescription`s. Perhaps we should introduce a new, more scalable method for validating correctness of `CallDescription`s because mistakes in them are embarrassingly common 🤔 https://github.com/llvm/llvm-project/pull/237154 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
