benedekaibas wrote:

> You may follow up with removing all sentence-ending dots (the change 
> previously planned as the "2nd PR") if you want, but that is a less urgent 
> change.

I think if we are already here, it makes sense to do it now. Then we would have 
consistent diagnostics across the CSA. Also merging these three PRs at the same 
time would also help downstream.

> but I'd suggest removing the part about (3) because "no consensus, will be 
> discussed later" is the default state of any change that is not mentioned 
> explicitly.

Good point, I have removed it. I also removed it from #228777.

https://github.com/llvm/llvm-project/pull/236804
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to