================
@@ -297,7 +300,16 @@ class Checker {
// step-function slowdowns due to CPU scaling.
// We take the median of 5 measurements, and after every check discard the
// measurement if the baseline changed by >3%.
- void checkTidyTimes() {
+ bool checkTidyTimes() {
+ // Keep all other modules active while varying only tidy's configuration.
+ auto *TidyModule =
+ Inputs.FeatureModules
+ ? Inputs.FeatureModules->get<ClangTidyFeatureModule>()
----------------
ArcsinX wrote:
> Just thinking out loud here: should the checkTiming be a function on the tidy
> module?
I think clang-tidy checks times calculation is too specific to be inside the
clang-tidy feature module. Currently, we use it only to generate fast/slow
checks list (and allow to run only fast checks by default).
> Should the module interface have a 'afterBuildAst' in their the interface or
> it's AST listener?
According to [this comment
](https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clangd/FeatureModule.h#L103),
I think this was originally intended to keep all AST-related hooks inside
`FeatureModule::ASTListener`. In AST listener we have
[afterExecute](https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clangd/FeatureModule.h#L140)
and we use it in this PR as a place where we run AST matchers.
https://github.com/llvm/llvm-project/pull/236054
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
