kazutakahirata wrote: > LGTM, although I think some of these could have been caught by the compiler > with `LLVM_ATTRIBUTE_WARN_UNUSED` (as mentioned in the LLVM PR).
Thanks for the review! Yes, I'm planning to introduce `LLVM_ATTRIBUTE_WARN_UNUSED` on several types. I'm cleaning up the codebase first so that patches to add `LLVM_ATTRIBUTE_WARN_UNUSED` don't have to clean up so many places at the same time. https://github.com/llvm/llvm-project/pull/237612 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
