benedekaibas wrote: @Ruhin575 Thank you for the PR. I have some questions/suggestions to the PR's description as well:
Questions: - I see you left out some of the functions from the issue. Do you plan to solve those in a follow up PR? Or did you try to implement support for those functions, but you encountered a blockage during implementation? If not that is totally fine I am just wondering. Suggestions: - `Built Clang successfully using ninja -C build clang`, `Ran security-syntax-checks.m using LLVM lit. All 4 test configurations passed.`, `Checked formatting using git-clang-format and whitespace using git diff --check.` -> I do not think these belong to the PR's description. These describe the baseline expectation that needs to be passed anyway. https://github.com/llvm/llvm-project/pull/234582 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
