ioeric added inline comments.
================
Comment at: clangd/ClangdUnit.cpp:377
+ : Result(&Result), SymbolScore(score(Result)), FilterScore(FilterScore),
+ Score(FilterScore * SymbolScore) {}
----------------
It might worth mentioning how well `FilterScore * SymbolScore` performs. I
think it could be affected by the distribution of the filtering score and
symbol scores. We might want to do some tweaks on the numbers depending on the
distributions...
================
Comment at: clangd/ClangdUnit.cpp:380
CodeCompletionResult *Result;
- float Score; // 0 to 1, higher is better.
+ float SymbolScore; // higher is better
+ float FilterScore; // 0 to 1, higher is better.
----------------
Any reason not to use `CompletionItemScores` here? Maybe copy over some
comments?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40780
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
