ioeric added inline comments.

================
Comment at: clangd/Context.h:63
+/// used as parents for some other Contexts.
+class Context {
+public:
----------------
sammccall wrote:
> I think we should strongly consider calling the class Ctx over Context. It's 
> going to appear in many function signatures, and I'm not sure the extra 
> characters buy us anything considering the abbreviation is pretty 
> unambiguous, and the full version isn't very explicit.
I have no opinion on the names... Just wondering: if the class is called `Ctx`, 
what name do you suggest to use for variables? With `Context`, you can probably 
use `Ctx`.  But... LLVM variable naming is sad... :(


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D40485



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to