MatzeB added a comment. Looks good to me, but I'm not too familiar with the clang driver code. So it would be good if you could at least add some more experienced clang developers into the reviewer list and wait some more days before committing.
I also wonder whether it would be possible to move the fact that it defaults to on for PS4 into the PS4CPU.cpp file somehow (not that things are distributed that cleanly right now anyway). https://reviews.llvm.org/D40712 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
