sdardis added inline comments.
================
Comment at: include/__libunwind_config.h:73
+# elif defined(_ABIN32) && defined(__mips_soft_float)
+# define _LIBUNWIND_TARGET_MIPS_NEWABI 1
+# define _LIBUNWIND_CONTEXT_SIZE 35
----------------
compnerd wrote:
> Minor nit: I prefer either `NABI` or `NEW_ABI`.
Normally mips documentation/source code either spells out n32/n64 when
referring to the 64 bit abis or calls it a variation of NewABI/newabi/NEWABI
(all one word).
================
Comment at: src/Registers.hpp:2252-2253
+#if defined(_LIBUNWIND_TARGET_MIPS_NEWABI)
+/// Registers_mips_newabi holds the register state of a thread in a NEWABI
+/// MIPS process including both the N32 and N64 ABIs.
+class _LIBUNWIND_HIDDEN Registers_mips_newabi {
----------------
Nit on the wording:
Registers_mips_newabi holds the register state of a thread in a NEWABI MIPS
process including both the N32 and N64 ABIs. ->
Registers_mips_newabi holds the register state of a thread in a MIPS process
using NEWABI (the N32 or N64 ABIs).
https://reviews.llvm.org/D39074
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
