Eugene.Zelenko added inline comments.
================ Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:169 + } +private: + SmallVector<StringRef, 1> CheckNames; ---------------- Please separate with empty line. ================ Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:170 +private: + SmallVector<StringRef, 1> CheckNames; + size_t NolintIndex = 0; ---------------- Please include header for SmallVector.h. ================ Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:339 std::unique_ptr<ClangTidyOptionsProvider> OptionsProvider) : DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)), + Profile(nullptr), ---------------- Please use default members initialization for DiagEngine and Profile. https://reviews.llvm.org/D41326 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits