klimek added a comment.

I've talked with Daniel and we both believe this patch is not the right way to 
go forward for clang-format. It is adding configuration mechanisms that we need 
to maintain going forward, without addressing a general problem; specifically 
for how to handle macros, I believe there is a clear better way to do it that 
is also fundamentally more useful than adding extra knobs for every problem we 
encounter. Finally, these changes do not address a fundamental bug, and 
workarounds exist, so there is no large benefit to do this now in a 
non-principled way rather than wait for a more principled fix. Overall, I do 
understand that this is a trade-off, but I hope you understand that we 
sometimes have to make decisions.


https://reviews.llvm.org/D37813



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to