craig.topper added inline comments.
================ Comment at: lib/CodeGen/CGCall.cpp:1737 llvm::toStringRef(CodeGenOpts.NoSignedZeros)); + FuncAttrs.addAttribute("shstk-compatible", + llvm::toStringRef(CodeGenOpts.ShstkCompatible)); ---------------- If the command line option is intended to be target independent, shouldn't these generically named? ================ Comment at: lib/CodeGen/CodeGenFunction.cpp:876 // Apply xray attributes to the function (as a string, for now) - if (D && ShouldXRayInstrumentFunction()) { + bool InstrumentXray = ShouldXRayInstrumentFunction(); + if (D && InstrumentXray) { ---------------- Why this change? Repository: rL LLVM https://reviews.llvm.org/D40478 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits