aaron.ballman accepted this revision.
aaron.ballman added a subscriber: dblaikie.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from a documentation nit, this LGTM. However, you should wait to commit
until after you can safely regenerate the AST matcher documentation. The issue
there is that dump_ast_matchers.py was not updated after r318304. I believe
@dblaikie was looking into the Python script, but I'm not certain how far he
got with it.
================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3579-3595
+/// struct b0 { [[noreturn]] b0(); };
+/// struct b1 { [[noreturn]] b1() {} };
+/// struct b2 { __attribute__((noreturn)) b2(); };
+/// struct b3 { __attribute__((noreturn)) b3() {} };
+/// struct c0 { [[noreturn]] int A(); };
+/// struct c1 { [[noreturn]] int A() {} };
+/// struct c2 { __attribute__((noreturn)) int A(); };
----------------
I don't think the documentation needs to list all of these -- it would be
better to pick a representative few and just use those.
Repository:
rC Clang
https://reviews.llvm.org/D41455
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
