I meant if the command line says “-mvaes -mno-aes” we should make sure to disable vaes
On Tue, Dec 26, 2017 at 9:47 AM coby via Phabricator < revi...@reviews.llvm.org> wrote: > coby added inline comments. > > > ================ > Comment at: lib/Basic/Targets/X86.cpp:573 > setMMXLevel(Features, AMD3DNowAthlon, Enabled); > } else if (Name == "aes") { > if (Enabled) > ---------------- > craig.topper wrote: > > Shouldn't -aes imply -vaes? > how come? perhaps i'm missing here something? > why would the first imply the latter? > following this road an atom z8XXX should be capable of supporting vaes, > for example (where it lacks avx, for example, > https://www.intel.com/content/www/us/en/processors/atom/atom-z8000-datasheet-vol-1.html > ) > also, in that sense, pclmul is implying vpclmulqdq > > > Repository: > rC Clang > > https://reviews.llvm.org/D41583 > > > > -- ~Craig
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits