ioeric added inline comments.
================
Comment at: clangd/CodeComplete.cpp:583
- Items->isIncomplete = !Index.fuzzyFind(Ctx, Req, [&](const Symbol &Sym) {
- Items->items.push_back(indexCompletionItem(Sym, Filter, SSInfo));
- });
+ // FIXME: figure out a way to merge the symbols from dynamic index and static
+ // index.
----------------
hokein wrote:
> ioeric wrote:
> > I would suggest also addressing this `FIXME` in this patch, or at least
> > make it possible to tell from which index source a candidate comes on the
> > client side. Simple concatenation from both indexes would make the results
> > hard to interpret, especially when we don't have a good merging algorithm
> > at this point.
> The FIXME is mainly about the merging algorithm.
>
> I still prefer to a follow-up on telling the client from which index source a
> completion item comes. I can foresee we might need to add an new field (like
> `Source`) in the `CompleitionItem`. Let's keep this patch simple at the
> moment.
I don't think we need additional field for this. We could manipulate the label
or detail of the completion item (e.g. adding a tag), which shouldn't be too
much extra work for this patch. IMO, concatenated results might easily be more
confusing than useful for our testing purpose at this point, given no merging
algorithm.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41668
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
