jbcoe added a comment. It might be worth adding some very simple get/set tests to ensure that properties are set as intended.
================ Comment at: tools/libclang/CIndex.cpp:4720 + +#define HANDLE_CASE(P, PROPERTY_NAME) \ + case CXPrintingPolicy_##PROPERTY_NAME: \ ---------------- I’m not convinced that the code replaced by the macro is sufficiently complicated to justify use of a macro. ================ Comment at: tools/libclang/CIndex.cpp:4763 +#undef HANDLE_CASE +#define HANDLE_CASE(P, PROPERTY_NAME, VALUE) \ + case CXPrintingPolicy_##PROPERTY_NAME: \ ---------------- I’m not convinced that the code replaced by the macro is sufficiently complicated to justify use of a macro. Repository: rC Clang https://reviews.llvm.org/D39903 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
