dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land.
LGTM with the TODO and the test case I requested inline. ================ Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:487 + if (const MemRegion *MR = I.second.getAsRegion()) + SymReaper.markElementIndicesLive(MR); + } ---------------- Do we have a test for the MemRegion case? Commenting it out doesn't seem to affect the tests. ================ Comment at: lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:607 + const CXXConstructExpr *CtorExpr = Ctor.getOriginExpr(); + const Stmt *ParentExpr = CurLC->getParentMap().getParent(CtorExpr); + ---------------- Can you add a TODO saying that we really shouldn't be using the parent map here? That is fragile and is a sign we're not providing enough context. https://reviews.llvm.org/D40560 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
