aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from a minor formatting nit. ================ Comment at: clang-tidy/hicpp/HICPPTidyModule.cpp:57 "hicpp-exception-baseclass"); - CheckFactories.registerCheck<SignedBitwiseCheck>( - "hicpp-signed-bitwise"); + CheckFactories.registerCheck<SignedBitwiseCheck>("hicpp-signed-bitwise"); CheckFactories.registerCheck<google::ExplicitConstructorCheck>( ---------------- Spurious formatting change -- feel free to commit separately (no review required) if you want to fix it. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41815 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits