ioeric added inline comments.
================ Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:109 + // Deduplicate the result by key. + // FIXME(ioeric): we need a better way to merge symbols with the same key. For + // example, class forward-declarations can have the same key as the class ---------------- sammccall wrote: > nit: this comment could be tightened up a bit: > > // FIXME(ioeric): Merge occurrences, rather than just dropping all but one. > // Definitions and forward declarations have the same key and may both have > information. > // Usage count will need to be aggregated across occurrences, too. Thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42113 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
