[PATCH] D42189: [clang-format] Replace unordered_set with an array

[Benjamin Kramer via Phabricator via cfe-commits]

bkramer added inline comments.


================
Comment at: lib/Format/Format.cpp:1424
                           const AdditionalKeywords &Keywords) {
-    static const std::unordered_set<StringRef> FoundationIdentifiers = {
+    static const llvm::ArrayRef<llvm::StringLiteral> FoundationIdentifiers = {
         "CGFloat",
----------------
The ArrayRef doesn't own its contents, so this is a use-after-scope.

I'd prefer `static constexpr llvm::StringLiteral FoundationIdentifiers[] = {`


Repository:
  rC Clang

https://reviews.llvm.org/D42189



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits