efriedma added inline comments.
================ Comment at: lib/CodeGen/CGClass.cpp:410 + + // The GEP is to a derived object, so this GEP must be 'inbounds'. + Value = Builder.CreateInBoundsGEP(Value, Builder.CreateNeg(NonVirtualOffset), ---------------- Not sure this comment really adds anything, unless you want to cite the standard. ================ Comment at: test/CodeGenCXX/catch-undef-behavior.cpp:391 // Alignment check from EmitTypeCheck(TCK_DowncastReference, ...) - // CHECK: [[SUB:%[.a-z0-9]*]] = getelementptr i8, i8* {{.*}}, i64 -16 + // CHECK: [[SUB:%[.a-z0-9]*]] = getelementptr inbounds i8, i8* {{.*}}, i64 -16 // CHECK-NEXT: [[C:%.+]] = bitcast i8* [[SUB]] to %class.C* ---------------- We probably want a test which checks the output when ubsan isn't enabled. https://reviews.llvm.org/D42249 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits