a.sidorin added a comment.
Hello Henry,
The patch looks reasonable. I think it can be landed after comments are
resolved.
================
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:1497
+ ExplodedNodeSet PostVisit;
+ for (ExplodedNodeSet::iterator i = PreVisit.begin(), e = PreVisit.end();
+ i != e; ++i) {
----------------
Could you C++11-fy this loop?
================
Comment at: test/Analysis/offsetofexpr-callback.c:3
+
+#include <stddef.h>
+
----------------
Answering your question, we should put the declaration into
system-header-simulator.h.
================
Comment at: test/Analysis/offsetofexpr-callback.c:7
+ char c;
+ double d;
+};
----------------
This decl seems unused. Should we remove it?
Repository:
rC Clang
https://reviews.llvm.org/D42300
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
