qcolombet added inline comments.
================
Comment at: lib/Driver/ToolChains/Clang.cpp:4699
+ else
+ CmdArgs.push_back("-global-isel=0");
+ }
----------------
I think that it would be useful to also set -global-isel-abort=2, so that users
can report problem early.
What do you think?
================
Comment at: lib/Driver/ToolChains/Clang.cpp:4699
+ else
+ CmdArgs.push_back("-global-isel=0");
+ }
----------------
qcolombet wrote:
> I think that it would be useful to also set -global-isel-abort=2, so that
> users can report problem early.
>
> What do you think?
>
>
Should we have some kind of "target validation"?
What I'd like to avoid is people trying the new allocator on unsupported target
(as in the GISel base classes are not present) that would just crash the
compiler.
Alternatively, we could fix the backend to fallback gracefully/abort properly
in those situation.
Right now I believe we would get a segfault on RegisterBankInfo or something
along those lines.
Repository:
rC Clang
https://reviews.llvm.org/D42276
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
