djasper added a comment.
I think I understand now. I think I'd prefer pulling all of the "+
UnbreakableTailLength" calculations out of getRemainingLength so that you don't
have to pass around the new parameter CanBreakAfter. Instead, only add it if
necessary outside of the function.
================
Comment at: lib/Format/BreakableToken.cpp:503
+ bool CanBreakAfter) const {
return UnbreakableTailLength +
getRangeLength(LineIndex, Offset, StringRef::npos, StartColumn);
----------------
Forgot to check CanBreakAfter here?
Repository:
rC Clang
https://reviews.llvm.org/D42372
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
