rjmccall added a comment.

In https://reviews.llvm.org/D42154#977991, @wmi wrote:

> In https://reviews.llvm.org/D42154#977975, @efriedma wrote:
>
> > The LLVM backend currently assumes every CPU is Pentium-compatible.  If 
> > we're going to change that in clang, we should probably fix the backend as 
> > well.
>
>
> With the patch, for i386/i486 targets, clang will generate more atomic 
> libcalls than before, for which llvm backend will not do anything extra, so 
> no fix is necessary in llvm backend for the patch to work.


I think Eli's point is that we do not currently support generating code for the 
386 and 486 because there are other things in the x86 backend that assume that 
the target is at minimum a Pentium.  If you're looking to support targeting 
those chips, you should look into that.

I don't have any objections to this patch.


Repository:
  rC Clang

https://reviews.llvm.org/D42154



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to