djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land.
Change the comment and possibly also the patch description along the lines of what I have suggested. Other than that, looks good to me. ================ Comment at: lib/Format/Format.cpp:679 + + // In protos, string literals are commonly multiline and already broken-up. + // Don't break them up even further, especially since we don't support ---------------- Make this comment: // Text protos are currently mostly formatted inside C++ raw string literals and // often the current breaking behavior of string literals is not beneficial there. // Investigate turning this on once proper string reflow has been implemented. Repository: rC Clang https://reviews.llvm.org/D42373 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits