george.karpenkov added a comment. looks good otherwise.
================ Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:418 + for (auto I : NewAllocValsMap) { + std::pair<const CXXNewExpr *, const LocationContext *> Key = I.first; + SVal Value = I.second; ---------------- indent? actually, an even better version would be probably moving those function back inline into printState, but instead moving out the lambdas passed to `dumpStack`. That would solve the eight-levels-of-indentation problem, and get rid of super-verbose lambdas https://reviews.llvm.org/D42560 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits